Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factory accepts Connector from Socket and deprecate legacy SocketClient #59

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Factory accepts Connector from Socket and deprecate legacy SocketClient #59

merged 1 commit into from
Sep 18, 2017

Conversation

clue
Copy link
Owner

@clue clue commented Sep 18, 2017

If you need custom connector settings (DNS resolution, TLS parameters, timeouts,
proxy servers etc.), you can explicitly pass a custom instance of the
ConnectorInterface:

$connector = new \React\Socket\Connector($loop, array(
    'dns' => '127.0.0.1',
    'tcp' => array(
        'bindto' => '192.168.10.1:0'
    ),
    'tls' => array(
        'verify_peer' => false,
        'verify_peer_name' => false
    )
));

$factory = new Factory($loop, $connector);

Builds on top of #58
Refs #50
Heavily inspired by clue/reactphp-buzz#76

@clue clue added this to the v1.2.0 milestone Sep 18, 2017
@clue clue merged commit d586c8e into clue:master Sep 18, 2017
@clue clue deleted the socket branch September 18, 2017 16:11
@clue clue mentioned this pull request Sep 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance new feature
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@clue